Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 )
Change subject: KUDU-2797: the master aggregates tablet statistics ...................................................................... Patch Set 19: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/13426/17/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/13426/17/src/kudu/tserver/ts_tablet_manager.cc@1307 PS17, Line 1307: { : ReportedTabletStatsPB stats_pb = replica->stats_pb(); : if (stats_pb.IsInitialized()) { : *reported_tablet->mutable_stats() = std::move(stats_pb); : } : } > I think it's not necessary to send the stats object which is not initialize Yeah, the `if` statement is fine, I just meant the extra curly braces. -- To view, visit http://gerrit.cloudera.org:8080/13426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I74406ab7cca7c22fda455c328b8ee9989a6b2d99 Gerrit-Change-Number: 13426 Gerrit-PatchSet: 19 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Thu, 27 Jun 2019 01:50:51 +0000 Gerrit-HasComments: Yes
