Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 )
Change subject: KUDU-2797: the master aggregates tablet statistics ...................................................................... Patch Set 20: (1 comment) Seems like Mike won't be able to get to this any time soon. Adar, I'm curious what your thoughts are w.r.t introducing a new metric entity, given it was a suggestion of yours a while back. http://gerrit.cloudera.org:8080/#/c/13426/20/src/kudu/master/table_metrics.cc File src/kudu/master/table_metrics.cc: PS20: One of the things that makes me hesitant about this is that it's introducing _even more_ metrics to Kudu, and specifically, a new metric entity (today, there are only two; adding a third seems like a big deal). Some thirdparty systems already struggle to handle the large volume of metrics that Kudu produces. I would have preferred to merge the previous approach of aggregating this elsewhere. But I could also be convinced. -- To view, visit http://gerrit.cloudera.org:8080/13426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I74406ab7cca7c22fda455c328b8ee9989a6b2d99 Gerrit-Change-Number: 13426 Gerrit-PatchSet: 20 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Tue, 16 Jul 2019 21:56:59 +0000 Gerrit-HasComments: Yes
