ZhangYao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13721 )

Change subject: KUDU-2847: Optimize iteration over selection vector in 
SerializeRowBlock
......................................................................


Patch Set 1:

After I do the benchmark https://gerrit.cloudera.org/#/c/13749/ , I found this 
may be a retrogression :(
Maybe my change break the cpu cache lines somehow. I will try another way to do 
this optimization later.
Here is the result(Before/After), I only pick the real time in the form below.
Total row count:100000

Schema size      3           30            300
Select rate
    1 0     0.004/0.195   2.209/2.159   24.947/35.265
    0.8     0.046/0.155   1.358/1.801   18.824/28.634
    0.5     0.048/0.102   0.823/1.182   12.799/17.946
    0.2     0.025/0.043   0.365/0.732   6.51/8.238


--
To view, visit http://gerrit.cloudera.org:8080/13721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19917d1875c46fd4cf98ef8a471b0340a76161e7
Gerrit-Change-Number: 13721
Gerrit-PatchSet: 1
Gerrit-Owner: ZhangYao <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Yao Xu <[email protected]>
Gerrit-Reviewer: ZhangYao <[email protected]>
Gerrit-Comment-Date: Thu, 27 Jun 2019 09:49:01 +0000
Gerrit-HasComments: No

Reply via email to