Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13721 )
Change subject: KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/13721/2/src/kudu/common/wire_protocol.cc File src/kudu/common/wire_protocol.cc: http://gerrit.cloudera.org:8080/#/c/13721/2/src/kudu/common/wire_protocol.cc@918 PS2, Line 918: convert_bitmap_to_vector style: this should be ConvertBitmapToVector http://gerrit.cloudera.org:8080/#/c/13721/2/src/kudu/common/wire_protocol.cc@923 PS2, Line 923: if (!sel_vec->AnySelected()) { : return; : } : if (sel_vec->CountSelected() == nrows) { seems like these two could be combined into just calling CountSelected once, since in the case that 'AnySelected' returns false, it would have passed over the whole array anyway http://gerrit.cloudera.org:8080/#/c/13721/2/src/kudu/common/wire_protocol.cc@935 PS2, Line 935: select_row_idx->resize(select_row_idx->size() + run_size); If you call CountSelected above and save the result, you can get a single resize() call, instead of one resize() per run -- To view, visit http://gerrit.cloudera.org:8080/13721 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19917d1875c46fd4cf98ef8a471b0340a76161e7 Gerrit-Change-Number: 13721 Gerrit-PatchSet: 2 Gerrit-Owner: ZhangYao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Yao Xu <[email protected]> Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Comment-Date: Tue, 16 Jul 2019 06:29:02 +0000 Gerrit-HasComments: Yes
