Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13757 )
Change subject: [docs] update Hive Metastore integration and Impala integration docs ...................................................................... Patch Set 1: (13 comments) http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc File docs/hive_metastore.adoc: http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@92 PS1, Line 92: `kudu hms check` and `kudu hms fix` Should mention `precheck` too? http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@102 PS1, Line 102: master-01.example.com,master-02.example.com,master-03.example.com Is the constraint here that this must match exactly with the value of some Impala configuration? If there is anything tricky about this value, we should call it out here, either as a NOTE or a WARNING. http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@108 PS1, Line 108: super Superuser has a special meaning in Kudu. We probably mean "trusted user" here. The user running the tool only needs to be able to view and modify data, not run any sort of administrative operation. http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@113 PS1, Line 113: check precheck http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@123 PS1, Line 123: Impala Should probably be `impala-shell`. Also, no beeline? http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@132 PS1, Line 132: : ## Upgrading Existing Tables I'm not sure how this renders. Will it be obvious that this should be done before moving onto "Enabling the Hive Metastore Integration"? http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@160 PS1, Line 160: . Note down all external tables. This can be helpful if catalog upgrade breaks any : external tables, due to the underlying Kudu tables being renamed. Is there a command for this in Impala? http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@169 PS1, Line 169: : . (Optional) If `kudu hms precheck` tool reports conflicting tables, rename these to : case-insensitive unique names using the following command: Why is this optional? http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@175 PS1, Line 175: renam_table rename_table http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@184 PS1, Line 184: Whether to ignore separate Kudu clusters that indicated by different set of master addresses (even only differ by port number). nit: Whether to ignore Kudu clusters that are different than the one being operated on, as indicated by a different set of master addresses, even if they only differ by port. http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@194 PS1, Line 194: dry run `kudu hms fix` tool nit: perform a dry-run of the `kudu hms fix` tool http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@201 PS1, Line 201: ignores_other_clusters ignore Also, maybe just make a NOTE or WARNING of this, rather than describing the same flag twice? http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@211 PS1, Line 211: Manually fix issues reported by the check tool but cannot be automatically fixed. : For example, rename Hive-incompatible tables. : Manually fix any issues that are reported by the check tool that cannot be automatically fixed. For example, rename any tables with names that are not Hive-conformant. -- To view, visit http://gerrit.cloudera.org:8080/13757 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8726a39d56c4e9954f208700e99e7bcf2bbc290d Gerrit-Change-Number: 13757 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 28 Jun 2019 19:45:12 +0000 Gerrit-HasComments: Yes
