Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13757 )
Change subject: [docs] update Hive Metastore integration and Impala integration docs ...................................................................... Patch Set 4: (11 comments) http://gerrit.cloudera.org:8080/#/c/13757/4/docs/kudu_impala_integration.adoc File docs/kudu_impala_integration.adoc: http://gerrit.cloudera.org:8080/#/c/13757/4/docs/kudu_impala_integration.adoc@102 PS4, Line 102: Work Working http://gerrit.cloudera.org:8080/#/c/13757/4/docs/kudu_impala_integration.adoc@104 PS4, Line 104: Impala integration nit: the Impala integration http://gerrit.cloudera.org:8080/#/c/13757/4/docs/kudu_impala_integration.adoc@104 PS4, Line 104: that ships with CDH 6.3 This probably belongs in CDH docs, rather than upstream. http://gerrit.cloudera.org:8080/#/c/13757/4/docs/kudu_impala_integration.adoc@104 PS4, Line 104: 1.10 nit: For consistency, 1.10.0? http://gerrit.cloudera.org:8080/#/c/13757/4/docs/kudu_impala_integration.adoc@105 PS4, Line 105: work with the Hive Metastore integration to take the advantage of automatically : catalog synchronization between Kudu and the HMS nit: maybe "can take advantage the automatic Kudu-HMS catalog synchronization enabled by the HMS integration" http://gerrit.cloudera.org:8080/#/c/13757/4/docs/kudu_impala_integration.adoc@106 PS4, Line 106: Since external table can map to : different Kudu tables with different names, and dropping an external table does not : drop the table from Kudu, only metadata of internal tables are automatically synchronized. How about "Since there is no one-to-one mapping between Kudu tables and external tables, only internal tables are automatically synchronized."? http://gerrit.cloudera.org:8080/#/c/13757/4/docs/kudu_impala_integration.adoc@109 PS4, Line 109: : NOTE: When Kudu's integration with the Hive Metastore is enabled, Impala should be : con Probably also worth pointing to the Kudu-HMS docs here. Also it's probably worth mentioning that even without the HMS integration enabled, Impala will still do the right thing. http://gerrit.cloudera.org:8080/#/c/13757/4/docs/kudu_impala_integration.adoc@110 PS4, Line 110: NOTE: When Kudu's integration with the Hive Metastore is enabled, Impala should be : configured to use the same Hive Metastore as Kudu. Would be good to discuss how to check this Impala configuration, and which Kudu flag this needs to be consistent with. http://gerrit.cloudera.org:8080/#/c/13757/4/docs/kudu_impala_integration.adoc@114 PS4, Line 114: : Without the Hive Metastore integration Without the HMS integration enabled http://gerrit.cloudera.org:8080/#/c/13757/4/docs/kudu_impala_integration.adoc@129 PS4, Line 129: However, such a manual process can be skipped with the Hive Metastore integration, : which an internal table with the same name will be automatically created by Kudu. : To query the table, you can simply run `invalidate metadata` to ensure Impala : is picking up the latest metadata. When the Kudu-HMS integration is enabled, internal table entries will be created automatically in the HMS when tables are created in Kudu without Impala. To access these tables through Impala, run `invalidate metadata` so Impala will pick up the latest metadata. http://gerrit.cloudera.org:8080/#/c/13757/4/docs/kudu_impala_integration.adoc@746 PS4, Line 746: change table type from intenral : to external (and vice versa) is disallowed, due to potential to introduce catalog inconsistency : between Kudu and the HMS. changing the table type is disallowed to avoid potentially introducing inconsistency between the Kudu and HMS catalogs. -- To view, visit http://gerrit.cloudera.org:8080/13757 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8726a39d56c4e9954f208700e99e7bcf2bbc290d Gerrit-Change-Number: 13757 Gerrit-PatchSet: 4 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Priyanka Chheda <[email protected]> Gerrit-Comment-Date: Tue, 02 Jul 2019 01:24:18 +0000 Gerrit-HasComments: Yes
