Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13782 )
Change subject: alter_schema_transaction-ToString function error_ condition is reverse, when error happens the server may crash ...................................................................... Patch Set 1: (1 comment) Thanks for catching this! http://gerrit.cloudera.org:8080/#/c/13782/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13782/1//COMMIT_MSG@7 PS1, Line 7: alter_schema_transaction-ToString function error_ condition is reverse, when error happens the server may crash nit: Can you split this into a title and a short body with a little bit of context? Maybe even include the stacktrace you saw upon failure? How did you see this fail? -- To view, visit http://gerrit.cloudera.org:8080/13782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7126edcdddae9cf21d343e6c6c219a003edb1be1 Gerrit-Change-Number: 13782 Gerrit-PatchSet: 1 Gerrit-Owner: XiaokaiWang <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu <[email protected]> Gerrit-Comment-Date: Tue, 02 Jul 2019 08:03:39 +0000 Gerrit-HasComments: Yes
