XiaokaiWang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13782 )
Change subject: [tserver] Fix bug in AlterSchemaTransactionState::ToString ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13782/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13782/1//COMMIT_MSG@7 PS1, Line 7: [tserver] Fix bug in AlterSchemaTransactionState::ToString > nit: Can you split this into a title and a short body with a little bit of stacktrace: 0x21f5dcc google::protobuf::TextFormat::Printer::Print() 0x21f5e6d google::protobuf::TextFormat::Printer::PrintToString() 0x204e335 kudu::pb_util::SecureShortDebugString() 0xbeae76 kudu::tablet::AlterSchemaTransactionState::ToString() 0xbead3f kudu::tablet::AlterSchemaTransaction::ToString() 0xbedaea kudu::tablet::TransactionDriver::ToString() 0xbf41e1 kudu::tablet::TransactionTracker::WaitForAllToFinish() 0xbf496f kudu::tablet::TransactionTracker::WaitForAllToFinish() 0xbe543f kudu::tablet::TabletReplica::Stop() 0x9cd198 kudu::tserver::TSTabletManager::DeleteTablet() 0x9d2f5f kudu::tserver::DeleteTabletRunnable::Run() 0x207365f kudu::ThreadPool::DispatchThread() 0x2068ec4 kudu::Thread::SuperviseThread() 0x7f01548b2dc5 start_thread 0x7f0152b8dced __clone In our environment, everyday we will delete old range partitions(three days ago). May it has much transactions and AlterSchema txn cost more than 1s, when dumping txns to string, the tserver crashed. http://gerrit.cloudera.org:8080/#/c/13782/1//COMMIT_MSG@7 PS1, Line 7: [tserver] Fix bug in AlterSchemaTransactionState::ToString > Need to wrap. Btw, I think the headline should be more concise. OK, thanks. -- To view, visit http://gerrit.cloudera.org:8080/13782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7126edcdddae9cf21d343e6c6c219a003edb1be1 Gerrit-Change-Number: 13782 Gerrit-PatchSet: 2 Gerrit-Owner: XiaokaiWang <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: XiaokaiWang <[email protected]> Gerrit-Reviewer: Yao Xu <[email protected]> Gerrit-Comment-Date: Tue, 02 Jul 2019 09:51:11 +0000 Gerrit-HasComments: Yes
