Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13780 )
Change subject: [docs] Add admin docs for backup and restore ...................................................................... Patch Set 1: (10 comments) http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc File docs/administration.adoc: http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@303 PS1, Line 303: Spark compatible > nit: Spark-compatible, here and below Done http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@310 PS1, Line 310: KuduBackup > nit: backticks Done http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@323 PS1, Line 323: les th > nit: add a comma Done http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@342 PS1, Line 342: Job > nit: lowercase? Done http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@344 PS1, Line 344: KuduRestore > nit: backticks Done http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@371 PS1, Line 371: hadoop classpath > Is this an actual command? If not, maybe this should be en environment vari This is an actual command. http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@396 PS1, Line 396: Currently the `toMs` time for the job. > Not sure I understand this Maybe I will just remove it. It's extra detail now worth explaining. http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@398 PS1, Line 398: linking > Might be worth adding a bit of description somewhere for what linking means True, I was worried that was a bit too much detail for admin docs and potentially an implementation detail that could change over time. Maybe a blog post or other docs location could be updated. http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@424 PS1, Line 424: General > lowercase Done http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@426 PS1, Line 426: Sparks > Spark's Done -- To view, visit http://gerrit.cloudera.org:8080/13780 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75f92d3f10fd5d970099e933d8de2d7662e03398 Gerrit-Change-Number: 13780 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 02 Jul 2019 22:07:30 +0000 Gerrit-HasComments: Yes
