Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13780 )
Change subject: [docs] Add admin docs for backup and restore ...................................................................... Patch Set 4: (6 comments) Probably worth adding a rendered version, saw a rendering issue here https://github.com/andrwng/kudu/blob/bdr-docs/docs/administration.adoc#backup http://gerrit.cloudera.org:8080/#/c/13780/4/docs/administration.adoc File docs/administration.adoc: http://gerrit.cloudera.org:8080/#/c/13780/4/docs/administration.adoc@327 PS4, Line 327: backups linked backups are linked http://gerrit.cloudera.org:8080/#/c/13780/4/docs/administration.adoc@336 PS4, Line 336: below nit: could link using <<>> http://gerrit.cloudera.org:8080/#/c/13780/4/docs/administration.adoc@336 PS4, Line 336: rootPath nit: backticks http://gerrit.cloudera.org:8080/#/c/13780/4/docs/administration.adoc@362 PS4, Line 362: : Commands: : * `list`: Lists the backups in the rootPath. : * `clean`: Cleans up old backup data in the rootPath. I think you need a newline after "Commands:"; this doesn't render as a list. http://gerrit.cloudera.org:8080/#/c/13780/4/docs/administration.adoc@431 PS4, Line 431: spark nit: uppercase http://gerrit.cloudera.org:8080/#/c/13780/4/docs/administration.adoc@432 PS4, Line 432: 50 columns. Not actionable I don't think, but I'm surprised this isn't some bytes-per-row or bytes-per-batch value or something. -- To view, visit http://gerrit.cloudera.org:8080/13780 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75f92d3f10fd5d970099e933d8de2d7662e03398 Gerrit-Change-Number: 13780 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 03 Jul 2019 00:26:26 +0000 Gerrit-HasComments: Yes
