ZhangYao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13749 )

Change subject: Extend benchmark for ColumnarRowBlockToPB.
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc
File src/kudu/common/wire_protocol-test.cc:

http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc@426
PS2, Line 426:   vector<double> select_rates = {1.0};
> maybe set these values if AllowSlowTests is true?
It seems that if set column_counts = {3, 30, 300} and select_rates = {1.0, 0.8, 
0.5, 0.2} when AllowSlowTests is true will exceed the unit test time limit :(



--
To view, visit http://gerrit.cloudera.org:8080/13749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie29937c316be624151e6c51e54545c4f023e603d
Gerrit-Change-Number: 13749
Gerrit-PatchSet: 4
Gerrit-Owner: ZhangYao <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Yao Xu <[email protected]>
Gerrit-Reviewer: ZhangYao <[email protected]>
Gerrit-Comment-Date: Thu, 04 Jul 2019 15:43:19 +0000
Gerrit-HasComments: Yes

Reply via email to