ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13749 )
Change subject: Extend benchmark for ColumnarRowBlockToPB. ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc File src/kudu/common/wire_protocol-test.cc: http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc@426 PS2, Line 426: // select_rates = {1.0, 0.8, 0.5, 0.2} for benchmark. > Maybe this will be better if you make 'kNumTrials' not affect the rowblock I will do it latter :) http://gerrit.cloudera.org:8080/#/c/13749/4/src/kudu/common/wire_protocol-test.cc File src/kudu/common/wire_protocol-test.cc: http://gerrit.cloudera.org:8080/#/c/13749/4/src/kudu/common/wire_protocol-test.cc@93 PS4, Line 93: ResetBenchmarkSchema > nit: Benchmark, not BenchMark Done http://gerrit.cloudera.org:8080/#/c/13749/4/src/kudu/common/wire_protocol-test.cc@151 PS4, Line 151: 10000, &arena); > why does the RowBlock size change based on the number of trials? I think we Actually I refer to the original code to implement this. I guess it would like larger rowblock when AllowSlowTests is true to make more adequate test. http://gerrit.cloudera.org:8080/#/c/13749/4/src/kudu/common/wire_protocol-test.cc@156 PS4, Line 156: faststring direct, indirect; > typo: Converting My mistake. http://gerrit.cloudera.org:8080/#/c/13749/4/src/kudu/common/wire_protocol-test.cc@160 PS4, Line 160: pb.Clear(); > probably would be good to init these outside the loop and just clear them i Done -- To view, visit http://gerrit.cloudera.org:8080/13749 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie29937c316be624151e6c51e54545c4f023e603d Gerrit-Change-Number: 13749 Gerrit-PatchSet: 5 Gerrit-Owner: ZhangYao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Yao Xu <[email protected]> Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Comment-Date: Tue, 09 Jul 2019 04:12:57 +0000 Gerrit-HasComments: Yes
