ZhangYao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13832 )

Change subject: Separate benchmark to single test
......................................................................


Patch Set 2:

(1 comment)

> (1 comment)
 >
 > How slow are these tests in DEBUG mode?

If I run with total 3 * 4 test, it will exceed the Jenkins unit test time limit 
in Debug mode. So I just seperate them and after that if someone want to extend 
the parameters of benchmark it can also work.

http://gerrit.cloudera.org:8080/#/c/13832/1/src/kudu/common/wire_protocol-test.cc
File src/kudu/common/wire_protocol-test.cc:

http://gerrit.cloudera.org:8080/#/c/13832/1/src/kudu/common/wire_protocol-test.cc@63
PS1, Line 63: class WireProtocolTest : public KuduTest,
> Doc up here that the int corresponds to the number of columns and the doubl
Done :)



--
To view, visit http://gerrit.cloudera.org:8080/13832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I980234bcdf76a7d2978f49ed59dff21184abf892
Gerrit-Change-Number: 13832
Gerrit-PatchSet: 2
Gerrit-Owner: ZhangYao <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: ZhangYao <[email protected]>
Gerrit-Comment-Date: Thu, 11 Jul 2019 02:44:12 +0000
Gerrit-HasComments: Yes

Reply via email to