Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13832 )
Change subject: Separate benchmark to single test ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13832/2/src/kudu/common/wire_protocol-test.cc File src/kudu/common/wire_protocol-test.cc: http://gerrit.cloudera.org:8080/#/c/13832/2/src/kudu/common/wire_protocol-test.cc@64 PS2, Line 64: /*Used for benchmark, int corresponds to the number of columns, : * double corresponds to the selection rate.*/ Nit: use C++-style commenting: // Used for benchmark, int corresponds to the number of columns, // double corresponds to the selection rate. -- To view, visit http://gerrit.cloudera.org:8080/13832 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I980234bcdf76a7d2978f49ed59dff21184abf892 Gerrit-Change-Number: 13832 Gerrit-PatchSet: 2 Gerrit-Owner: ZhangYao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Comment-Date: Thu, 11 Jul 2019 04:55:07 +0000 Gerrit-HasComments: Yes
