helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 )
Change subject: KUDU-2797 p2: the master aggregates tablet statistics ...................................................................... Patch Set 22: (2 comments) Two questions remain: 1. More unit tests coverage on the aggregated metrics; 2. Should we avoid publishing a value until all tservers report? https://gerrit.cloudera.org/#/c/13426/20/src/kudu/master/catalog_manager.cc@4171 http://gerrit.cloudera.org:8080/#/c/13426/21//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13426/21//COMMIT_MSG@13 PS21, Line 13: 1) disk size and live row count of all the replicas are : aggregated on the master server (only the ones that are : the leadership roles are aggregated); : 2) disk size and li > You should now remove these from the patch (and the commit message). Done http://gerrit.cloudera.org:8080/#/c/13426/20/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/13426/20/src/kudu/master/catalog_manager.cc@370 PS20, Line 370: table->RegisterMetrics(catalog_manager_->master_->metric_registry(), metadata.name()); > Yeah we should probably publish both the table ID and name. But, we should I think the table name in the metadata should be a normalized string already. And the above example just a case without HMS. -- To view, visit http://gerrit.cloudera.org:8080/13426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I74406ab7cca7c22fda455c328b8ee9989a6b2d99 Gerrit-Change-Number: 13426 Gerrit-PatchSet: 22 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Fri, 19 Jul 2019 09:38:14 +0000 Gerrit-HasComments: Yes
