Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 )
Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 ...................................................................... Patch Set 22: (4 comments) http://gerrit.cloudera.org:8080/#/c/13760/22//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13760/22//COMMIT_MSG@15 PS22, Line 15: The maximum length for VARCHAR is 65,535 and 255 for CHAR Could you add _why_ these maximum lengths make sense? http://gerrit.cloudera.org:8080/#/c/13760/22/src/kudu/common/partial_row.h File src/kudu/common/partial_row.h: http://gerrit.cloudera.org:8080/#/c/13760/22/src/kudu/common/partial_row.h@415 PS22, Line 415: /// Get the string/binary value for a column by its name. This sentence should also be updated. http://gerrit.cloudera.org:8080/#/c/13760/22/src/kudu/common/partial_row.h@438 PS22, Line 438: /// Get the string/binary value for a column by its index. Likewise. http://gerrit.cloudera.org:8080/#/c/13760/20/src/kudu/common/schema.h File src/kudu/common/schema.h: http://gerrit.cloudera.org:8080/#/c/13760/20/src/kudu/common/schema.h@124 PS20, Line 124: // Maximum value of the length is 65,535 for compatibility reasons as it's : // used by VARCHAR type which can be set to a maximum of 65,535 in case of : // MySQL and less for other major RDMBMS implementations. > I believe it should be char quantity, at least in other RDBMSs I used it wa Thanks for the clarification. Could you update the comment to reflect that the length is a character quantity? -- To view, visit http://gerrit.cloudera.org:8080/13760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I998982dba93831db91c43a97ce30d3e68c2a4a54 Gerrit-Change-Number: 13760 Gerrit-PatchSet: 22 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 19 Jul 2019 15:49:00 +0000 Gerrit-HasComments: Yes
