Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 )
Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 ...................................................................... Patch Set 24: (1 comment) > Patch Set 24: Code-Review+2 > > (1 comment) > > Looks good to me, though let's hold off merging until you've tested this with > Impala. http://gerrit.cloudera.org:8080/#/c/13760/23/src/kudu/common/partial_row.h File src/kudu/common/partial_row.h: http://gerrit.cloudera.org:8080/#/c/13760/23/src/kudu/common/partial_row.h@153 PS23, Line 153: /// @note The copying behavior is new for these methods starting Kudu 0.10. : /// Prior to Kudu 0.10, these methods behaved like : /// KuduPartialRow::SetStringNoCopy() and KuduPartialRow::SetBinaryNoCopy() : /// correspondingly. > Nah, not worth it. Let's just skip the NoCopy variants for now; we can alwa Done -- To view, visit http://gerrit.cloudera.org:8080/13760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I998982dba93831db91c43a97ce30d3e68c2a4a54 Gerrit-Change-Number: 13760 Gerrit-PatchSet: 24 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 23 Jul 2019 21:15:57 +0000 Gerrit-HasComments: Yes
