Yifan Zhang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13937 )

Change subject: [ksck] Filter tables and tablets in KsckCluster
......................................................................


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/13937/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/13937/2//COMMIT_MSG@9
PS2, Line 9: executes
> Nit: executes
Done


http://gerrit.cloudera.org:8080/#/c/13937/2/src/kudu/tools/ksck-test.cc
File src/kudu/tools/ksck-test.cc:

http://gerrit.cloudera.org:8080/#/c/13937/2/src/kudu/tools/ksck-test.cc@201
PS2, Line 201: for (auto it = tables_.begin(); it != tables_.end();)  {
             :       if (!MatchesAnyPattern(tabl
> for (auto& it = tables_.begin(); it != tables_.end(); ) {
Done


http://gerrit.cloudera.org:8080/#/c/13937/2/src/kudu/tools/ksck-test.cc@213
PS2, Line 213: sh
> '& '
Done


http://gerrit.cloudera.org:8080/#/c/13937/2/src/kudu/tools/ksck-test.cc@215
PS2, Line 215:   if (!MatchesAnyPattern(tablet_id_filters_, (*it)->id())) {
             :           it = tablets.erase(it);
> for (auto& it = tablets.begin(); it != tablets.end(); ) {
Done



--
To view, visit http://gerrit.cloudera.org:8080/13937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23b6e6ef258d3498a42af7f92b63392a59c99761
Gerrit-Change-Number: 13937
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Mon, 29 Jul 2019 03:52:05 +0000
Gerrit-HasComments: Yes

Reply via email to