Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13937 )
Change subject: [ksck] Filter tables and tablets in KsckCluster ...................................................................... Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/13937/5/src/kudu/tools/ksck-test.cc File src/kudu/tools/ksck-test.cc: http://gerrit.cloudera.org:8080/#/c/13937/5/src/kudu/tools/ksck-test.cc@54 PS5, Line 54: #include "kudu/util/test_util.h" > Not sorted correctly. Done http://gerrit.cloudera.org:8080/#/c/13937/5/src/kudu/tools/ksck-test.cc@200 PS5, Line 200: virtual Status RetrieveTablesList() override { > I don't understand why these changes were needed. Are there any calls to se Since table_filters and tablet_id_filters has been moved to KsckCluster, then we got a filtered `tables_` in RetrieveTablesList()/RetrieveTabletsList(), and it's also needed to filter tables/tablets in MockKsckMaster for tests. set_table_filters/set_tablet_id_filters called in tests for testing matching filters. http://gerrit.cloudera.org:8080/#/c/13937/5/src/kudu/tools/ksck.h File src/kudu/tools/ksck.h: http://gerrit.cloudera.org:8080/#/c/13937/5/src/kudu/tools/ksck.h@452 PS5, Line 452: // Setters for filtering the tables/tablets to be checked. > I think having this API on the Ksck class is nicer; that's typically the cl Okay, this API and filters in KsckChecksumOptions reserved, though they have no use now. http://gerrit.cloudera.org:8080/#/c/13937/5/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/13937/5/src/kudu/tools/ksck.cc@591 PS5, Line 591: if (table->tablets().empty()) { > Do we actually need to make a copy of this list of tablets? Or could we jus Done http://gerrit.cloudera.org:8080/#/c/13937/5/src/kudu/tools/ksck_checksum.cc File src/kudu/tools/ksck_checksum.cc: http://gerrit.cloudera.org:8080/#/c/13937/5/src/kudu/tools/ksck_checksum.cc@502 PS5, Line 502: msg += " Filter:"; > Can you help me understand the motivation for this change? It's for passing the test`TestNonMatchingTabletIdFilter`. Actually I also don't understand the meaning of original comments here, it seems all tablets counted in `num_tablets` and only filted replicas counted in `num_replicas_tmp`. -- To view, visit http://gerrit.cloudera.org:8080/13937 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23b6e6ef258d3498a42af7f92b63392a59c99761 Gerrit-Change-Number: 13937 Gerrit-PatchSet: 6 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 02 Aug 2019 07:45:32 +0000 Gerrit-HasComments: Yes
