Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14000 )
Change subject: KUDU-2849 Docker image for python kudu client ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/14000/5/docker/Dockerfile File docker/Dockerfile: http://gerrit.cloudera.org:8080/#/c/14000/5/docker/Dockerfile@226 PS5, Line 226: RUN pip install --upgrade pip Is this required? http://gerrit.cloudera.org:8080/#/c/14000/5/docker/Dockerfile@228 PS5, Line 228: COPY ./python/requirements.txt /kudu/python/requirements.txt Move this with the other COPY statements. You can use the same workdir as below since requirements.txt will get removed after it's used. http://gerrit.cloudera.org:8080/#/c/14000/5/docker/Dockerfile@231 PS5, Line 231: RUN pip install -r requirements.txt I think this can all be done in one step/layer in the run below. We should also remove the requirements.txt in that step. It's important because each action taken in the dockerfile creates a new layer that make the image larger. https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#minimize-the-number-of-layers -- To view, visit http://gerrit.cloudera.org:8080/14000 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7cab8ffe114c73752c261f27ebc7a58e4b57a6e Gerrit-Change-Number: 14000 Gerrit-PatchSet: 5 Gerrit-Owner: Sandish Kumar HN <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Sandish Kumar HN <[email protected]> Gerrit-Comment-Date: Mon, 05 Aug 2019 12:36:02 +0000 Gerrit-HasComments: Yes
