Sandish Kumar HN has posted comments on this change. ( http://gerrit.cloudera.org:8080/14000 )
Change subject: KUDU-2849 Docker image for python kudu client ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/14000/5/docker/Dockerfile File docker/Dockerfile: http://gerrit.cloudera.org:8080/#/c/14000/5/docker/Dockerfile@226 PS5, Line 226: ENV LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/usr/local/lib64 > Is this required? it complains lie "You are using pip version 18.1, however version 19.2.1 is available.", but passes the step http://gerrit.cloudera.org:8080/#/c/14000/5/docker/Dockerfile@228 PS5, Line 228: # Copy the requirements file. > Move this with the other COPY statements. You can use the same workdir as b done http://gerrit.cloudera.org:8080/#/c/14000/5/docker/Dockerfile@231 PS5, Line 231: COPY --from=build /kudu/python/dist/kudu-python-*.tar.gz . > I think this can all be done in one step/layer in the run below. We should done -- To view, visit http://gerrit.cloudera.org:8080/14000 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7cab8ffe114c73752c261f27ebc7a58e4b57a6e Gerrit-Change-Number: 14000 Gerrit-PatchSet: 6 Gerrit-Owner: Sandish Kumar HN <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Sandish Kumar HN <[email protected]> Gerrit-Comment-Date: Tue, 06 Aug 2019 22:21:24 +0000 Gerrit-HasComments: Yes
