Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13470 )
Change subject: [tserver] Move cell and probe key size checking to prepare phase ...................................................................... [tserver] Move cell and probe key size checking to prepare phase It's inefficient to check cell and probe key size in apply phase, because we have to lock row key and construct new Slices for every binary type of columns. This patch move this lightweight checking to prepare phase when decoding values from protobuf and before locking row keys. Change-Id: Id3e672272bb1dcf2d0ac1d96ee8a1a2d1489774c Reviewed-on: http://gerrit.cloudera.org:8080/13470 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Adar Dembo <[email protected]> Reviewed-by: Todd Lipcon <[email protected]> --- M src/kudu/clock/clock.h M src/kudu/common/row_operations-test.cc M src/kudu/common/row_operations.cc M src/kudu/common/row_operations.h M src/kudu/tablet/row_op.cc M src/kudu/tablet/row_op.h M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet.h M src/kudu/tablet/tablet_bootstrap.cc 9 files changed, 240 insertions(+), 87 deletions(-) Approvals: Adar Dembo: Looks good to me, but someone else must approve; Verified Todd Lipcon: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/13470 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id3e672272bb1dcf2d0ac1d96ee8a1a2d1489774c Gerrit-Change-Number: 13470 Gerrit-PatchSet: 11 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]>
