Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13470 )
Change subject: [tserver] Move cell and probe key size checking to prepare phase ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/13470/6/src/kudu/common/row_operations.h File src/kudu/common/row_operations.h: http://gerrit.cloudera.org:8080/#/c/13470/6/src/kudu/common/row_operations.h@107 PS6, Line 107: // Read one row's column data from 'src_', read result is stored in 'slice'. : // Return bad Status if data is corrupt. : // NOTE: If 'row_status' is not nullptr, column data validate will be performed, : // and if column data validate error (i.e. column size ex > Should also add how setting row_status to nullptr or not will affect column Done http://gerrit.cloudera.org:8080/#/c/13470/6/src/kudu/common/row_operations.cc File src/kudu/common/row_operations.cc: http://gerrit.cloudera.org:8080/#/c/13470/6/src/kudu/common/row_operations.cc@421 PS6, Line 421: if (PREDICT_FALSE(!row_status.ok())) op->SetFailureStatusOnce(row_status); > Could PREDICT_FALSE here. Done http://gerrit.cloudera.org:8080/#/c/13470/6/src/kudu/common/row_operations.cc@518 PS6, Line 518: if (PREDICT_FALSE(!row_status.ok())) op->SetFailureStatusOnce(row_status); > Could PREDICT_FALSE here. Done -- To view, visit http://gerrit.cloudera.org:8080/13470 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id3e672272bb1dcf2d0ac1d96ee8a1a2d1489774c Gerrit-Change-Number: 13470 Gerrit-PatchSet: 7 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 30 Jul 2019 03:42:04 +0000 Gerrit-HasComments: Yes
