Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14045 )
Change subject: [thirdparty] Bump LZ4 to version 1.9.1 ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14045/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14045/2//COMMIT_MSG@9 PS2, Line 9: New version of LZ4 have some speed improvements, we ought to : upgrade it. Curious whether you benchmarked or otherwise quantified these improvements in Kudu? http://gerrit.cloudera.org:8080/#/c/14045/2/src/kudu/util/CMakeLists.txt File src/kudu/util/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/14045/2/src/kudu/util/CMakeLists.txt@317 PS2, Line 317: add_definitions(-DLZ4_DISABLE_DEPRECATE_WARNINGS) Use https://cmake.org/cmake/help/latest/command/target_compile_definitions.html if the intent is to only affect kudu_util_compression. Also, please add a comment rationalizing the need for this definition. -- To view, visit http://gerrit.cloudera.org:8080/14045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11c0de2db6d524b7f40c905a2a0abb0cb12a281b Gerrit-Change-Number: 14045 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 13 Aug 2019 06:23:53 +0000 Gerrit-HasComments: Yes
