Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14045 )
Change subject: [thirdparty] Bump LZ4 to version 1.9.1 ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14045/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14045/2//COMMIT_MSG@9 PS2, Line 9: New version of LZ4 have some speed improvements, we ought to : upgrade it. > I did some simple benchmark tests in https://gerrit.cloudera.org/c/14045/1 Maybe, the buffers which contain the data are too small? According to https://github.com/lz4/lz4/releases/tag/v1.9.0, even between 1.8.3 and 1.9.1 there should be up to 18% speed improvement for some cases while decompressing. Not sure how it's related to completely random data used in the referenced tests. -- To view, visit http://gerrit.cloudera.org:8080/14045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11c0de2db6d524b7f40c905a2a0abb0cb12a281b Gerrit-Change-Number: 14045 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 16 Aug 2019 17:06:04 +0000 Gerrit-HasComments: Yes
