Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13580 )
Change subject: [metrics] Merge metrics by the same attribute ...................................................................... Patch Set 10: (4 comments) It'd be great to get another review from someone more familiar with the metrics system. Todd, could you take a look? We need to be extra careful because Impala uses the Kudu metrics library by virtue of its consumption of krpc. http://gerrit.cloudera.org:8080/#/c/13580/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13580/10//COMMIT_MSG@14 PS10, Line 14: http://<host>:<port>/metrics?merge_rules=tablet|table|table_name Should probably surround table_name with triangular brackets (i.e. <table_name>) to indicate that it's a value that should be replaced, like <host> or <port>. http://gerrit.cloudera.org:8080/#/c/13580/10/src/kudu/util/hdr_histogram.h File src/kudu/util/hdr_histogram.h: http://gerrit.cloudera.org:8080/#/c/13580/10/src/kudu/util/hdr_histogram.h@174 PS10, Line 174: MergeFrom 'other' HdrHistogram object Nit: "Merges 'other' into this HdrHistogram. Values in each..." http://gerrit.cloudera.org:8080/#/c/13580/10/src/kudu/util/metrics.h File src/kudu/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/13580/10/src/kudu/util/metrics.h@744 PS10, Line 744: // MergeFrom 'other' metric object. Nit: "Merges 'other' into this Metric object." http://gerrit.cloudera.org:8080/#/c/13580/10/src/kudu/util/metrics.cc File src/kudu/util/metrics.cc: http://gerrit.cloudera.org:8080/#/c/13580/10/src/kudu/util/metrics.cc@71 PS10, Line 71: JsonWriter * Nit: "JsonWriter* " Below too; the pointer or reference character should be next to the type. -- To view, visit http://gerrit.cloudera.org:8080/13580 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8db3d082ae847eb1d83b9e4aee57d5e4bf13e1b5 Gerrit-Change-Number: 13580 Gerrit-PatchSet: 10 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 13 Aug 2019 07:10:17 +0000 Gerrit-HasComments: Yes
