Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13580 )
Change subject: [metrics] Merge metrics by the same attribute ...................................................................... Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/13580/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13580/10//COMMIT_MSG@14 PS10, Line 14: http://<host>:<port>/metrics?merge_rules=tablet|table|table_name > Should probably surround table_name with triangular brackets (i.e. <table_n 'table_name' here is itself, not a table name value, it indicate to the 'table_name' atrribute of 'tablet'. [ { "type": "tablet", "id": "4e375f2469b54c97b620d7b1cd31b69a", "attributes": { "partition": "HASH (id) PARTITION 4, RANGE (olap_date) PARTITION 20190816 <= VALUES < 20190817", "table_name": "default.kudu_test_partiton_table", # This attribute name "table_id": "c49771e2387046cea6f73a5e6907d237" }, "metrics": [...] } ] http://gerrit.cloudera.org:8080/#/c/13580/10/src/kudu/util/hdr_histogram.h File src/kudu/util/hdr_histogram.h: http://gerrit.cloudera.org:8080/#/c/13580/10/src/kudu/util/hdr_histogram.h@174 PS10, Line 174: Merges 'other' into this HdrHistogram > Nit: "Merges 'other' into this HdrHistogram. Values in each..." Done http://gerrit.cloudera.org:8080/#/c/13580/10/src/kudu/util/metrics.h File src/kudu/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/13580/10/src/kudu/util/metrics.h@744 PS10, Line 744: // Merges 'other' into this Metric > Nit: "Merges 'other' into this Metric object." Done http://gerrit.cloudera.org:8080/#/c/13580/10/src/kudu/util/metrics.cc File src/kudu/util/metrics.cc: http://gerrit.cloudera.org:8080/#/c/13580/10/src/kudu/util/metrics.cc@71 PS10, Line 71: JsonWriter* > Nit: "JsonWriter* " Done -- To view, visit http://gerrit.cloudera.org:8080/13580 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8db3d082ae847eb1d83b9e4aee57d5e4bf13e1b5 Gerrit-Change-Number: 13580 Gerrit-PatchSet: 11 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 15 Aug 2019 09:59:52 +0000 Gerrit-HasComments: Yes
