Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14070 )
Change subject: [test] Make the kudu-admin-test more rubust by adding AssertEventually ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14070/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14070/1//COMMIT_MSG@9 PS1, Line 9: Sometimes it's possible the scan will not immediately retrieve the row : even though the write has already succeeded, therefore add AssertEventually : to assure the scan return the right result. It will make the test case more robust. > Agreed when the scan follows a drop range partition, but we don't need it e +1 Since CountTableRows() use LEADER_ONLY scan mode and the prior write operation succeeds, the rows should be there. Adding ASSERT_EVENTUALLY in such cases would mask a bug (if any appears). -- To view, visit http://gerrit.cloudera.org:8080/14070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied2993acaf35eef9d177f7e3cd1cd62ea9a1cdfb Gerrit-Change-Number: 14070 Gerrit-PatchSet: 1 Gerrit-Owner: honeyhexin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 15 Aug 2019 16:40:10 +0000 Gerrit-HasComments: Yes
