honeyhexin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14070 )
Change subject: [test] Make the kudu-admin-test more robust by adding AssertEventually ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/14070/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14070/1//COMMIT_MSG@7 PS1, Line 7: robust > robust Done http://gerrit.cloudera.org:8080/#/c/14070/1/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/14070/1/src/kudu/tools/kudu-admin-test.cc@2394 PS1, Line 2394: ASSERT_OK(client_->OpenTable(kTableId, &table)); > Or here. Done http://gerrit.cloudera.org:8080/#/c/14070/1/src/kudu/tools/kudu-admin-test.cc@2434 PS1, Line 2434: } > Or here. Done http://gerrit.cloudera.org:8080/#/c/14070/1/src/kudu/tools/kudu-admin-test.cc@2535 PS1, Line 2535: // which will return error in lambda as we expect. > Or here. Done http://gerrit.cloudera.org:8080/#/c/14070/1/src/kudu/tools/kudu-admin-test.cc@2564 PS1, Line 2564: ASSERT_EVENTUALLY([&]() { > Or here. Done http://gerrit.cloudera.org:8080/#/c/14070/1/src/kudu/tools/kudu-admin-test.cc@2847 PS1, Line 2847: "drop_range_partition", > Don't need it here. Oops, I made a mistake. I will fix it. -- To view, visit http://gerrit.cloudera.org:8080/14070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied2993acaf35eef9d177f7e3cd1cd62ea9a1cdfb Gerrit-Change-Number: 14070 Gerrit-PatchSet: 2 Gerrit-Owner: honeyhexin <honeyhe...@sohu.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: honeyhexin <honeyhe...@sohu.com> Gerrit-Comment-Date: Thu, 15 Aug 2019 22:25:05 +0000 Gerrit-HasComments: Yes
