Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14095 )
Change subject: small cleanup: remove unnecessary semicolons (part 2) ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/14095/1/src/kudu/util/debug/trace_event.h File src/kudu/util/debug/trace_event.h: http://gerrit.cloudera.org:8080/#/c/14095/1/src/kudu/util/debug/trace_event.h@887 PS1, Line 887: #define INTERNAL_TRACE_EVENT_ADD_SCOPED(category_group, name, ...) \ > I think this change caused the trace tests to fail, probably due to the new Whoops, indeed -- those are related to the scope, so no new scope should be introduced. Good catch! http://gerrit.cloudera.org:8080/#/c/14095/1/src/kudu/util/status.h File src/kudu/util/status.h: PS1: > The changes potentially break API compatibility for clients that have used Yup, I think due to the prevalent usage patterns of RETURN_NOT_OK() and friends, we should not expect many are affected by this update. I added a note into the commit message. -- To view, visit http://gerrit.cloudera.org:8080/14095 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I59cbffccdfe9ca0dcd634515d041213420675dec Gerrit-Change-Number: 14095 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 20 Aug 2019 01:05:30 +0000 Gerrit-HasComments: Yes
