Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/14095 )
Change subject: small cleanup: remove unnecessary semicolons (part 2)
......................................................................
small cleanup: remove unnecessary semicolons (part 2)
Removed trailing semicolon from the definitions of various macros
that are defined using the `do { ... } while (false)` clause.
Updated all call sites where the trailing semicolon was missing.
Being a minor change, this patch might break compilation of client
applications using Kudu C++ client's headers of prior versions
if RETURN_NOT_OK() and other macros were used without trailing semicolon
at call sites. However, due to the prevalent usage patterns of the
RETURN_NOT_OK() macro and friends in the existing code base and examples,
we should not expect anybody to be affected by this small cleanup.
The motivation for this change was finding numerous warnings output
by the built-in static analysis tools while browsing through the code
using the newer version of QtCreator IDE.
This patch does not contain any functional changes.
Change-Id: I59cbffccdfe9ca0dcd634515d041213420675dec
Reviewed-on: http://gerrit.cloudera.org:8080/14095
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <[email protected]>
---
M src/kudu/client/client-test.cc
M src/kudu/codegen/codegen-test.cc
M src/kudu/common/partial_row.cc
M src/kudu/consensus/log-test.cc
M src/kudu/consensus/log_anchor_registry.cc
M src/kudu/consensus/log_reader.cc
M src/kudu/fs/error_manager.h
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/hms/hms_client-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/client-negotiation-failover-itest.cc
M src/kudu/integration-tests/tombstoned_voting-imc-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
M src/kudu/mini-cluster/internal_mini_cluster.cc
M src/kudu/tablet/mvcc.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/thrift/client.h
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/rebalancer_tool-test.cc
M src/kudu/tools/tool_action_cluster.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/util/env_posix.cc
M src/kudu/util/file_cache-stress-test.cc
M src/kudu/util/scoped_cleanup.h
M src/kudu/util/status.h
M src/kudu/util/subprocess-test.cc
M src/kudu/util/test_macros.h
M src/kudu/util/trace.h
33 files changed, 98 insertions(+), 105 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14095
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I59cbffccdfe9ca0dcd634515d041213420675dec
Gerrit-Change-Number: 14095
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
