Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14111 )
Change subject: KUDU-2069 pt 1: add a maintenance mode ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/14111/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14111/1//COMMIT_MSG@12 PS1, Line 12: : - Reduce the logging when a peer can't be reached This is more a TODO. I'll remove it from the commit message and address this in a follow-up patch. http://gerrit.cloudera.org:8080/#/c/14111/1/src/kudu/master/maintenance_state-test.cc File src/kudu/master/maintenance_state-test.cc: http://gerrit.cloudera.org:8080/#/c/14111/1/src/kudu/master/maintenance_state-test.cc@113 PS1, Line 113: // Generates a tablet report with the given health statuses for the consensus : // states. : ReportedTabletPB GenerateReportedTabletPB( : const unordered_map<string, bool> consensus_health_map) { : return ReportedTabletPB(); : } Will remove. http://gerrit.cloudera.org:8080/#/c/14111/1/src/kudu/master/ts_manager.cc File src/kudu/master/ts_manager.cc: http://gerrit.cloudera.org:8080/#/c/14111/1/src/kudu/master/ts_manager.cc@182 PS1, Line 182: // Now that we've registered the TS, in case the TS was previously : // unregistered, drop any maintenance states. : unregistered_maintenance_states_.erase(uuid); move up -- To view, visit http://gerrit.cloudera.org:8080/14111 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia857668b87560cdd451c2e7f90d72f8217ba5a4b Gerrit-Change-Number: 14111 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 21 Aug 2019 17:48:45 +0000 Gerrit-HasComments: Yes
