Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14111 )
Change subject: KUDU-2069 pt 1: add a maintenance mode ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/14111/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14111/2//COMMIT_MSG@10 PS2, Line 10: failures of T will not be considered when determining : whether a given tablet is under-replicated > I don't explicitly mention this in the design doc, but going by what I desc I was thinking of special error code for reporting purposes at this point, but after some consideration that doesn't sound like a necessity. Overall, whoever operates the cluster should let users know that there is a maintenance window and some tablet servers might be unavailable. As for postponing creating the proper number of replicas for later, I don't think it's worth to introduce such a complexity, at list at this point, yep. http://gerrit.cloudera.org:8080/#/c/14111/2//COMMIT_MSG@23 PS2, Line 23: whitelist > I was struggling to come to a term that aptly described the behavior and la OK. http://gerrit.cloudera.org:8080/#/c/14111/2/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/14111/2/src/kudu/master/master.proto@816 PS2, Line 816: optional MaintenanceStatePB state > I don't think that is necessary right now, but I'll write it so we can in t Yeah, I looked around as of now I don't see any cases which would require 'setting at once' semantics. -- To view, visit http://gerrit.cloudera.org:8080/14111 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia857668b87560cdd451c2e7f90d72f8217ba5a4b Gerrit-Change-Number: 14111 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 26 Aug 2019 13:49:45 +0000 Gerrit-HasComments: Yes
