Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13916 )
Change subject: [clock] introduce mini_chronyd ...................................................................... Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/13916/4/src/kudu/clock/test/mini_chronyd-test.cc File src/kudu/clock/test/mini_chronyd-test.cc: http://gerrit.cloudera.org:8080/#/c/13916/4/src/kudu/clock/test/mini_chronyd-test.cc@143 PS4, Line 143: // servers as a reliable source for time synchronisation via NTP. > It doesn't matter from which point they are all offset, the important thing The new comment is clear but I don't see how the code follows it: the argument value passed to SetTime() is the same for all five servers. http://gerrit.cloudera.org:8080/#/c/13916/5/src/kudu/clock/test/mini_chronyd.cc File src/kudu/clock/test/mini_chronyd.cc: http://gerrit.cloudera.org:8080/#/c/13916/5/src/kudu/clock/test/mini_chronyd.cc@73 PS5, Line 73: offset "the offset"? http://gerrit.cloudera.org:8080/#/c/13916/5/src/kudu/clock/test/mini_chronyd.cc@75 PS5, Line 75: have has http://gerrit.cloudera.org:8080/#/c/13916/5/src/kudu/clock/test/mini_chronyd.cc@76 PS5, Line 76: successfully successful http://gerrit.cloudera.org:8080/#/c/13916/5/src/kudu/clock/test/mini_chronyd.cc@75 PS5, Line 75: find them as a reliable : // NTP clock source first "deem them to be a reliable NTP clock source first"? http://gerrit.cloudera.org:8080/#/c/13916/5/src/kudu/clock/test/mini_chronyd.cc@78 PS5, Line 78: seem as "appear to be a" http://gerrit.cloudera.org:8080/#/c/13916/5/src/kudu/clock/test/mini_chronyd.cc@82 PS5, Line 82: // The 'minpoll' parameter is set to the smallest possible that is supported Mind reformatting this as a list, so it's easier to add/remove configuration elements later? -- To view, visit http://gerrit.cloudera.org:8080/13916 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9d06d218828240f2a2980ef5ec30428f86277f7 Gerrit-Change-Number: 13916 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 26 Aug 2019 04:46:29 +0000 Gerrit-HasComments: Yes
