Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13916 )
Change subject: [clock] introduce mini_chronyd ...................................................................... Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/13916/4/src/kudu/clock/test/mini_chronyd-test.cc File src/kudu/clock/test/mini_chronyd-test.cc: http://gerrit.cloudera.org:8080/#/c/13916/4/src/kudu/clock/test/mini_chronyd-test.cc@143 PS4, Line 143: ASSERT_OK(servers[i]->SetTime(ref_time + 10)); > The new comment is clear but I don't see how the code follows it: the argum Whoops, good catch! That's was a typo. http://gerrit.cloudera.org:8080/#/c/13916/5/src/kudu/clock/test/mini_chronyd.cc File src/kudu/clock/test/mini_chronyd.cc: http://gerrit.cloudera.org:8080/#/c/13916/5/src/kudu/clock/test/mini_chronyd.cc@73 PS5, Line 73: > "the offset"? Done http://gerrit.cloudera.org:8080/#/c/13916/5/src/kudu/clock/test/mini_chronyd.cc@75 PS5, Line 75: "se > has Done http://gerrit.cloudera.org:8080/#/c/13916/5/src/kudu/clock/test/mini_chronyd.cc@75 PS5, Line 75: burst version 3\n"; : if (servers.empty()) { > "deem them to be a reliable NTP clock source first"? Done http://gerrit.cloudera.org:8080/#/c/13916/5/src/kudu/clock/test/mini_chronyd.cc@76 PS5, Line 76: > successful Done http://gerrit.cloudera.org:8080/#/c/13916/5/src/kudu/clock/test/mini_chronyd.cc@78 PS5, Line 78: > "appear to be a" Done http://gerrit.cloudera.org:8080/#/c/13916/5/src/kudu/clock/test/mini_chronyd.cc@82 PS5, Line 82: } > Mind reformatting this as a list, so it's easier to add/remove configuratio Done -- To view, visit http://gerrit.cloudera.org:8080/13916 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9d06d218828240f2a2980ef5ec30428f86277f7 Gerrit-Change-Number: 13916 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 26 Aug 2019 14:49:15 +0000 Gerrit-HasComments: Yes
