Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14122 )
Change subject: KUDU-2907: add a dir to dir groups when full ...................................................................... Patch Set 2: (3 comments) Didn't review it fully, just left a few questions. http://gerrit.cloudera.org:8080/#/c/14122/2/src/kudu/fs/data_dirs.cc File src/kudu/fs/data_dirs.cc: http://gerrit.cloudera.org:8080/#/c/14122/2/src/kudu/fs/data_dirs.cc@1121 PS2, Line 1121: // Associate the tablet with the new data dir. Don't we also need to flush the tablet's superblock with an updated DataDirGroupPB? http://gerrit.cloudera.org:8080/#/c/14122/2/src/kudu/fs/data_dirs.cc@1124 PS2, Line 1124: EmplaceOrUpdate(&group_by_tablet_map_, tablet_id, DataDirGroup(group_uuid_indices)); Aren't we guaranteed to do an update rather than an emplace? Could we enforce that? http://gerrit.cloudera.org:8080/#/c/14122/2/src/kudu/fs/data_dirs.cc@1126 PS2, Line 1126: LOG(INFO) << Substitute("Added $0 to $1's directory group", (*dir)->dir(), tablet_id); Should also LOG why? Would be useful if we could include numbers. -- To view, visit http://gerrit.cloudera.org:8080/14122 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7 Gerrit-Change-Number: 14122 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Comment-Date: Mon, 26 Aug 2019 22:57:54 +0000 Gerrit-HasComments: Yes
