Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14122 )
Change subject: KUDU-2907: add a dir to dir groups when full ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/14122/2/src/kudu/fs/data_dirs.cc File src/kudu/fs/data_dirs.cc: http://gerrit.cloudera.org:8080/#/c/14122/2/src/kudu/fs/data_dirs.cc@134 PS2, Line 134: using std::pair; > warning: using decl 'iota' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/14122/2/src/kudu/fs/data_dirs.cc@1121 PS2, Line 1121: // dir already, and we should update the existing data dir group. > Don't we also need to flush the tablet's superblock with an updated DataDir Yes, this will happen when we flush the tablet metadata next (e.g. when a new block is written; if no new block is written, the updated group shouldn't matter). When we serialize the superblock, we fetch the data dir group from the ddmanager rather than relying on some in-memory cached value. There's a test for this in tablet_server-test.cc http://gerrit.cloudera.org:8080/#/c/14122/2/src/kudu/fs/data_dirs.cc@1124 PS2, Line 1124: CHECK(!EmplaceOrUpdate(&group_by_tablet_map_, tablet_id, DataDirGroup(group_uuid_indices))); > Aren't we guaranteed to do an update rather than an emplace? Could we enfor Done http://gerrit.cloudera.org:8080/#/c/14122/2/src/kudu/fs/data_dirs.cc@1126 PS2, Line 1126: LOG(INFO) << Substitute("Added $0 to $1's directory group: $2", > Should also LOG why? Would be useful if we could include numbers. Done -- To view, visit http://gerrit.cloudera.org:8080/14122 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7 Gerrit-Change-Number: 14122 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Comment-Date: Tue, 27 Aug 2019 00:44:09 +0000 Gerrit-HasComments: Yes
