Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14122 )
Change subject: KUDU-2907: add a dir to dir groups when full ...................................................................... Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/14122/8/src/kudu/fs/data_dirs.cc File src/kudu/fs/data_dirs.cc: http://gerrit.cloudera.org:8080/#/c/14122/8/src/kudu/fs/data_dirs.cc@1091 PS8, Line 1091: DataDirManager > Nit: DataDirManager Done http://gerrit.cloudera.org:8080/#/c/14122/8/src/kudu/fs/data_dirs.cc@1092 PS8, Line 1092: those in the : // TabletSuperB > Do you mean "those in the TabletSuperBlockPB"? Done http://gerrit.cloudera.org:8080/#/c/14122/8/src/kudu/util/env_util.cc File src/kudu/util/env_util.cc: http://gerrit.cloudera.org:8080/#/c/14122/8/src/kudu/util/env_util.cc@23 PS8, Line 23: #include <cerrno> > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/14122/8/src/kudu/util/env_util.cc@42 PS8, Line 42: #include "kudu/util/fault_injection.h" > warning: #includes are not sorted properly [llvm-include-order] Done -- To view, visit http://gerrit.cloudera.org:8080/14122 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7 Gerrit-Change-Number: 14122 Gerrit-PatchSet: 9 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Comment-Date: Tue, 27 Aug 2019 20:18:27 +0000 Gerrit-HasComments: Yes
