Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14107 )
Change subject: KUDU-2921: Exposing the table statistics to spark relation. ...................................................................... Patch Set 3: (4 comments) How do the new Java APIs react when running against an old server that doesn't support the new RPC? What about the Spark client? http://gerrit.cloudera.org:8080/#/c/14107/3/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTableStatistics.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduTableStatistics.java: http://gerrit.cloudera.org:8080/#/c/14107/3/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTableStatistics.java@52 PS3, Line 52: * Get the table's live row count. Should note pre-replication here too. http://gerrit.cloudera.org:8080/#/c/14107/3/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala: http://gerrit.cloudera.org:8080/#/c/14107/3/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala@270 PS3, Line 270: It : * is always better to overestimate this size than underestimate. Why? Could you expand the comment? http://gerrit.cloudera.org:8080/#/c/14107/2/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/14107/2/src/kudu/master/catalog_manager.cc@271 PS2, Line 271: DEFINE_bool(mock_table_metrics_for_testing, false, : "Whether to enable mock table metrics for testing."); : TAG_FLAG(mock_table_metrics_for_testing, runtime); : TAG_FLAG(mock_table_metrics_for_testing, unsafe); : : DEFINE_int64(on_disk_size_for_testing, 0, : "Mock the on disk size of metrics for testing."); : TAG_FLAG(on_disk_size_for_testing, runtime); : TAG_FLAG(on_disk_size_for_testing, unsafe); : : DEFINE_int64(live_row_count_for_testing, 0, : "Mock the live row count of metrics for testing."); : TAG_FLAG(live_row_count_for_testing, runtime); : TAG_FLAG(live_row_count_for_testing, unsafe); > According to the comment about Flag tags, it seems tagged as unsafe will ex I see. OK, I guess it's fine then. http://gerrit.cloudera.org:8080/#/c/14107/3/src/kudu/master/sentry_authz_provider.cc File src/kudu/master/sentry_authz_provider.cc: http://gerrit.cloudera.org:8080/#/c/14107/3/src/kudu/master/sentry_authz_provider.cc@258 PS3, Line 258: // Table statistics contains data requires scan privilege so it require : // SELECT privilege here. "Table statistics contain data and thus requires the 'SELECT ON TABLE' privilege." -- To view, visit http://gerrit.cloudera.org:8080/14107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7742a76708f989b0ccc8ba417f3390013e260175 Gerrit-Change-Number: 14107 Gerrit-PatchSet: 3 Gerrit-Owner: ZhangYao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Comment-Date: Wed, 28 Aug 2019 18:59:52 +0000 Gerrit-HasComments: Yes
