ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14107 )
Change subject: KUDU-2921: Exposing the table statistics to spark relation. ...................................................................... Patch Set 4: (3 comments) > (4 comments) > > How do the new Java APIs react when running against an old server > that doesn't support the new RPC? What about the Spark client? 1. For java client when using new RPC: new java client -> old server -> leads to execption new java client -> new server -> works normally old java client -> old server -> works normally old java client -> new server -> works normally 2. For spark client: new spark client depends on new java client. new spark client -> old server -> leads to execption new spark client -> new server -> works normally old spark client can works with both old and new spark client old spark client -> old server -> works normally old spark client -> new server -> works normally So new spark client needs new java clients needs new server. http://gerrit.cloudera.org:8080/#/c/14107/3/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTableStatistics.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduTableStatistics.java: http://gerrit.cloudera.org:8080/#/c/14107/3/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTableStatistics.java@52 PS3, Line 52: * Get the table's live row count, this statistic is pre-replication. > Should note pre-replication here too. Done http://gerrit.cloudera.org:8080/#/c/14107/3/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala: http://gerrit.cloudera.org:8080/#/c/14107/3/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala@270 PS3, Line 270: It : * is always better to overestimate this size than underestimate, > Why? Could you expand the comment? Done http://gerrit.cloudera.org:8080/#/c/14107/3/src/kudu/master/sentry_authz_provider.cc File src/kudu/master/sentry_authz_provider.cc: http://gerrit.cloudera.org:8080/#/c/14107/3/src/kudu/master/sentry_authz_provider.cc@258 PS3, Line 258: // Table statistics contain data and thus requires the 'SELECT ON TABLE' privilege. : return Authorize(SentryAu > "Table statistics contain data and thus requires the 'SELECT ON TABLE' priv Done -- To view, visit http://gerrit.cloudera.org:8080/14107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7742a76708f989b0ccc8ba417f3390013e260175 Gerrit-Change-Number: 14107 Gerrit-PatchSet: 4 Gerrit-Owner: ZhangYao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Comment-Date: Thu, 29 Aug 2019 07:00:34 +0000 Gerrit-HasComments: Yes
