Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14172 )
Change subject: [gutil] introduce CLOCK_MONOTONIC_RAW (on linux) ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/14172/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14172/2//COMMIT_MSG@14 PS2, Line 14: CLOCK_MONOTINIC_RAW typo here http://gerrit.cloudera.org:8080/#/c/14172/2//COMMIT_MSG@16 PS2, Line 16: a drop http://gerrit.cloudera.org:8080/#/c/14172/2/src/kudu/gutil/walltime-test.cc File src/kudu/gutil/walltime-test.cc: http://gerrit.cloudera.org:8080/#/c/14172/2/src/kudu/gutil/walltime-test.cc@38 PS2, Line 38: No invariants are : // verified/enforced. Maybe just remove these tests then? It's pretty clear from clock_gettime() what CLOCK_MONOTONIC_RAW does, and if we're not actually testing anything, what's the point? http://gerrit.cloudera.org:8080/#/c/14172/2/src/kudu/gutil/walltime.h File src/kudu/gutil/walltime.h: http://gerrit.cloudera.org:8080/#/c/14172/2/src/kudu/gutil/walltime.h@175 PS2, Line 175: being drop -- To view, visit http://gerrit.cloudera.org:8080/14172 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88c787fe7aee6aa55943cbadfd2be4f43053f6ad Gerrit-Change-Number: 14172 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 04 Sep 2019 04:29:05 +0000 Gerrit-HasComments: Yes
