Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14172 )
Change subject: [gutil] introduce CLOCK_MONOTONIC_RAW ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/14172/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14172/2//COMMIT_MSG@14 PS2, Line 14: CLOCK_MONOTONIC_RAW > typo here Done http://gerrit.cloudera.org:8080/#/c/14172/2//COMMIT_MSG@16 PS2, Line 16: t > drop Done http://gerrit.cloudera.org:8080/#/c/14172/2/src/kudu/gutil/walltime-test.cc File src/kudu/gutil/walltime-test.cc: http://gerrit.cloudera.org:8080/#/c/14172/2/src/kudu/gutil/walltime-test.cc@38 PS2, Line 38: : > Maybe just remove these tests then? It's pretty clear from clock_gettime() Yep, there is not much behind these. I was more curios about how much different those measurements might be. On a Linux machine with update of a few years, the output was: [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from WallTimeTest [ RUN ] WallTimeTest.MonotonicVsMonotonicRawOffset WARNING: Logging before InitGoogleLogging() is written to STDERR I0904 13:57:28.767266 114964 walltime-test.cc:54] now 58451699632263 now_raw 58451255636446 I0904 13:57:28.767406 114964 walltime-test.cc:54] now 58451699632265 now_raw 58451255636447 I0904 13:57:28.767418 114964 walltime-test.cc:54] now 58451699632267 now_raw 58451255636449 I0904 13:57:28.767428 114964 walltime-test.cc:54] now 58451699632268 now_raw 58451255636450 I0904 13:57:28.767439 114964 walltime-test.cc:54] now 58451699632270 now_raw 58451255636452 I0904 13:57:28.767449 114964 walltime-test.cc:54] now 58451699632271 now_raw 58451255636453 I0904 13:57:28.767459 114964 walltime-test.cc:54] now 58451699632273 now_raw 58451255636455 I0904 13:57:28.767469 114964 walltime-test.cc:54] now 58451699632274 now_raw 58451255636456 I0904 13:57:28.767479 114964 walltime-test.cc:54] now 58451699632276 now_raw 58451255636458 I0904 13:57:28.767489 114964 walltime-test.cc:54] now 58451699632277 now_raw 58451255636459 I0904 13:57:28.767516 114964 walltime-test.cc:69] now_raw 58451255636713 now 58451699632532 I0904 13:57:28.767527 114964 walltime-test.cc:69] now_raw 58451255636715 now 58451699632533 I0904 13:57:28.767537 114964 walltime-test.cc:69] now_raw 58451255636717 now 58451699632535 I0904 13:57:28.767547 114964 walltime-test.cc:69] now_raw 58451255636718 now 58451699632536 I0904 13:57:28.767557 114964 walltime-test.cc:69] now_raw 58451255636720 now 58451699632538 I0904 13:57:28.767567 114964 walltime-test.cc:69] now_raw 58451255636721 now 58451699632539 I0904 13:57:28.767577 114964 walltime-test.cc:69] now_raw 58451255636723 now 58451699632541 I0904 13:57:28.767587 114964 walltime-test.cc:69] now_raw 58451255636724 now 58451699632542 I0904 13:57:28.767597 114964 walltime-test.cc:69] now_raw 58451255636725 now 58451699632544 I0904 13:57:28.767607 114964 walltime-test.cc:69] now_raw 58451255636727 now 58451699632545 [ OK ] WallTimeTest.MonotonicVsMonotonicRawOffset (0 ms) [----------] 1 test from WallTimeTest (0 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (0 ms total) [ PASSED ] 1 test. http://gerrit.cloudera.org:8080/#/c/14172/2/src/kudu/gutil/walltime.h File src/kudu/gutil/walltime.h: http://gerrit.cloudera.org:8080/#/c/14172/2/src/kudu/gutil/walltime.h@175 PS2, Line 175: meMic > drop Done -- To view, visit http://gerrit.cloudera.org:8080/14172 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88c787fe7aee6aa55943cbadfd2be4f43053f6ad Gerrit-Change-Number: 14172 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 04 Sep 2019 21:02:21 +0000 Gerrit-HasComments: Yes
