Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14107 )
Change subject: KUDU-2921: Exposing the table statistics to spark relation. ...................................................................... Patch Set 7: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/14107/7/src/kudu/master/sentry_authz_provider-test.cc File src/kudu/master/sentry_authz_provider-test.cc: http://gerrit.cloudera.org:8080/#/c/14107/7/src/kudu/master/sentry_authz_provider-test.cc@822 PS7, Line 822: // Authorize the SELECT privilege of the database should imply the table. : TSentryPrivilege privilege = GetDatabasePrivilege("db", "SELECT"); : ASSERT_OK(AlterRoleGrantPrivilege(privilege)); : ASSERT_OK(sentry_authz_provider_->AuthorizeGetTableStatistics("db.table", kTestUser)); : : // Authorize the SELECT privilege of the table. : ASSERT_OK(AlterRoleGrantPrivilege(GetTablePrivilege("db", "table", "SELECT"))); : ASSERT_OK(sentry_authz_provider_->AuthorizeGetTableStatistics("db.table", kTestUser)); The second test case is a bit redundant as once granting SELECT on DB it should imply SELECT on Table. You can just keep either one of these two test cases. http://gerrit.cloudera.org:8080/#/c/14107/7/src/kudu/master/sentry_authz_provider.cc File src/kudu/master/sentry_authz_provider.cc: http://gerrit.cloudera.org:8080/#/c/14107/7/src/kudu/master/sentry_authz_provider.cc@258 PS7, Line 258: Table statistics contain data nit: contain data (e.g. number of rows) that requires the 'SELECT ON TABLE' privilege. -- To view, visit http://gerrit.cloudera.org:8080/14107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7742a76708f989b0ccc8ba417f3390013e260175 Gerrit-Change-Number: 14107 Gerrit-PatchSet: 7 Gerrit-Owner: ZhangYao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Comment-Date: Fri, 06 Sep 2019 21:28:31 +0000 Gerrit-HasComments: Yes
