ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14107 )
Change subject: KUDU-2921: Exposing the table statistics to spark relation. ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/14107/7/src/kudu/master/sentry_authz_provider-test.cc File src/kudu/master/sentry_authz_provider-test.cc: http://gerrit.cloudera.org:8080/#/c/14107/7/src/kudu/master/sentry_authz_provider-test.cc@822 PS7, Line 822: // Authorize get table statistics on a user with proper privileges. : TSentryPrivilege privilege = GetDatabasePrivilege("db", "SELECT"); : ASSERT_OK(AlterRoleGrantPrivilege(privilege)); : ASSERT_OK(sentry_authz_provider_->AuthorizeGetTableStatistics("db.table", kTestUser)); : } : : TEST_F(SentryAuthzProviderTest, TestAuthorizeGetTableMetadata) { : // Don't authorize getting metadata on a table for a user without required > The second test case is a bit redundant as once granting SELECT on DB it sh Done http://gerrit.cloudera.org:8080/#/c/14107/7/src/kudu/master/sentry_authz_provider.cc File src/kudu/master/sentry_authz_provider.cc: http://gerrit.cloudera.org:8080/#/c/14107/7/src/kudu/master/sentry_authz_provider.cc@258 PS7, Line 258: Statistics contain data (e.g. > nit: contain data (e.g. number of rows) that requires the 'SELECT ON TABLE' Done -- To view, visit http://gerrit.cloudera.org:8080/14107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7742a76708f989b0ccc8ba417f3390013e260175 Gerrit-Change-Number: 14107 Gerrit-PatchSet: 8 Gerrit-Owner: ZhangYao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Comment-Date: Sat, 07 Sep 2019 14:59:23 +0000 Gerrit-HasComments: Yes
