[email protected] has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14192 )

Change subject: [examples] Example shell scripts to start and stop Kudu cluster
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/14192/1//COMMIT_MSG
Commit Message:

PS1:
> Maybe, a better place would be examples/toy_cluster ?  'scripts' sounds too
I think that we have examples "cpp" for C++, "python" for Python ... and it's 
sounds like we should have "scripts" for shell scripts


http://gerrit.cloudera.org:8080/#/c/14192/1/examples/quickstart/scripts/start_kudu.sh
File examples/quickstart/scripts/start_kudu.sh:

http://gerrit.cloudera.org:8080/#/c/14192/1/examples/quickstart/scripts/start_kudu.sh@62
PS1, Line 62: start_tserver tserver-0 9870 9871 8765
            : start_tserver tserver-1 9872 9873 8765
            : start_tserver tserver-2 9874 9875 8765
> Is it possible to deduce the RPC and webserver ports from the index of the
It's done explicitly for purpose of simplicity


http://gerrit.cloudera.org:8080/#/c/14192/1/examples/quickstart/scripts/start_kudu.sh@66
PS1, Line 66: ps -eo args | egrep "kudu-(master|tserver)"
> What is this for?
It just shows what processes got actually started and their parameters


http://gerrit.cloudera.org:8080/#/c/14192/1/examples/quickstart/scripts/stop_kudu.sh
File examples/quickstart/scripts/stop_kudu.sh:

http://gerrit.cloudera.org:8080/#/c/14192/1/examples/quickstart/scripts/stop_kudu.sh@5
PS1, Line 5: ps -eo args | egrep "kudu-(master|tserver)"
> What is this for?
It shows that all processes were successfully killed and nothing was left 
behind.



--
To view, visit http://gerrit.cloudera.org:8080/14192
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e7bb66d4cce84d00d346bf50154f449d48e7a54
Gerrit-Change-Number: 14192
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Greg Solovyev <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 07 Sep 2019 00:51:52 +0000
Gerrit-HasComments: Yes

Reply via email to