Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14192 )
Change subject: Example shell scripts to start and stop Kudu cluster ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/14192/6/examples/quickstart/scripts/start_kudu.sh File examples/quickstart/scripts/start_kudu.sh: http://gerrit.cloudera.org:8080/#/c/14192/6/examples/quickstart/scripts/start_kudu.sh@27 PS6, Line 27: > Does this work properly if your cwd is somewhere else and you're running th I introduced --builddir parameter http://gerrit.cloudera.org:8080/#/c/14192/6/examples/quickstart/scripts/start_kudu.sh@31 PS6, Line 31: > May also want this to be configurable. Done http://gerrit.cloudera.org:8080/#/c/14192/6/examples/quickstart/scripts/start_kudu.sh@95 PS6, Line 95: : : : : : > Maybe you could allow the ports to be configurable via env variables? Seems Done http://gerrit.cloudera.org:8080/#/c/14192/6/examples/quickstart/scripts/start_kudu.sh@95 PS6, Line 95: : : : : : > I agree with Adar -- it's better have a way to configure, say, 'base port n Done -- To view, visit http://gerrit.cloudera.org:8080/14192 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e7bb66d4cce84d00d346bf50154f449d48e7a54 Gerrit-Change-Number: 14192 Gerrit-PatchSet: 7 Gerrit-Owner: Volodymyr Verovkin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Fri, 13 Sep 2019 21:56:54 +0000 Gerrit-HasComments: Yes
