Sandish Kumar HN has posted comments on this change. ( http://gerrit.cloudera.org:8080/14202 )
Change subject: [kudu-client] KUDU-2910 Add Singleton Class KuduClientCache to kudu client module and can used across different integration like spark, Hive etc.. ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/14202/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduClientCache.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduClientCache.java: http://gerrit.cloudera.org:8080/#/c/14202/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduClientCache.java@38 PS1, Line 38: private final Map<String, ClientCacheValue> clientCache = Collections.synchronizedMap(new HashMap<>()); > It's a static constant, right? How about: SHUTDOWN_HOOK_PRIORITY is not available in java lib shutdown hook. http://gerrit.cloudera.org:8080/#/c/14202/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduClientCache.java@41 PS1, Line 41: private KuduClientCache() {} > This should be moved ahead of the non-static members so it's more prominent Adar, I'm making sure it stays as singleton class -- To view, visit http://gerrit.cloudera.org:8080/14202 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08f7bbd4f1f1223ac80175d4ab3eabe9c841ddf8 Gerrit-Change-Number: 14202 Gerrit-PatchSet: 3 Gerrit-Owner: Sandish Kumar HN <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Sandish Kumar HN <[email protected]> Gerrit-Comment-Date: Tue, 10 Sep 2019 05:32:53 +0000 Gerrit-HasComments: Yes
