Sandish Kumar HN has posted comments on this change. ( http://gerrit.cloudera.org:8080/14202 )
Change subject: [kudu-client] KUDU-2910 Add Singleton Class KuduClientCache to kudu client module and can used across different integration like spark, Hive etc.. ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/14202/7/java/kudu-client/src/main/java/org/apache/kudu/client/KuduClientCache.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduClientCache.java: http://gerrit.cloudera.org:8080/#/c/14202/7/java/kudu-client/src/main/java/org/apache/kudu/client/KuduClientCache.java@60 PS7, Line 60: AsyncKuduClient asyncClient = new AsyncKuduClient.AsyncKuduClientBuilder(kuduMasters).build(); > You don't need to declare a new local variable; you could reuse asyncKuduCl Tried, after below asyncClient = new AsyncKuduClient.AsyncKuduClientBuilder(kuduMasters).build(); Run method expecting a final variable Variable 'asyncKuduClient' is accessible within the inner class, needs to be the final effect -- To view, visit http://gerrit.cloudera.org:8080/14202 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08f7bbd4f1f1223ac80175d4ab3eabe9c841ddf8 Gerrit-Change-Number: 14202 Gerrit-PatchSet: 7 Gerrit-Owner: Sandish Kumar HN <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Sandish Kumar HN <[email protected]> Gerrit-Comment-Date: Wed, 11 Sep 2019 00:15:13 +0000 Gerrit-HasComments: Yes
