Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14218 )
Change subject: Add get table statistics interface for cpp client ...................................................................... Patch Set 1: Code-Review+1 (3 comments) LGTM, just a few nits. http://gerrit.cloudera.org:8080/#/c/14218/1/src/kudu/client/table_statistics-internal.h File src/kudu/client/table_statistics-internal.h: http://gerrit.cloudera.org:8080/#/c/14218/1/src/kudu/client/table_statistics-internal.h@17 PS1, Line 17: #ifndef KUDU_TABLE_STATISTICS_INTERNAL_H : #define KUDU_TABLE_STATISTICS_INTERNAL_H nit: use #pragma once for new code http://gerrit.cloudera.org:8080/#/c/14218/1/src/kudu/client/table_statistics-internal.h@20 PS1, Line 20: #include <stdint.h> nit: use #include <cstdint> for new code http://gerrit.cloudera.org:8080/#/c/14218/1/src/kudu/client/table_statistics-internal.cc File src/kudu/client/table_statistics-internal.cc: PS1: nit: These are super small and don't require extra includes. Consider putting these in the header? -- To view, visit http://gerrit.cloudera.org:8080/14218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic00f46fd49c258f46a178a92d142d4d93d615d82 Gerrit-Change-Number: 14218 Gerrit-PatchSet: 1 Gerrit-Owner: ZhangYao <triplesheep0...@gmail.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 12 Sep 2019 16:46:17 +0000 Gerrit-HasComments: Yes
