ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14218 )
Change subject: Add get table statistics interface for cpp client ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/14218/1/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/14218/1/src/kudu/client/client.h@463 PS1, Line 463: /// > Nit: separate this from the function description with an empty line. Done http://gerrit.cloudera.org:8080/#/c/14218/1/src/kudu/client/client.h@465 PS1, Line 465: /// Name of the table. > Note that the caller takes ownership of the statistics structure. Done http://gerrit.cloudera.org:8080/#/c/14218/1/src/kudu/client/table_statistics-internal.h File src/kudu/client/table_statistics-internal.h: http://gerrit.cloudera.org:8080/#/c/14218/1/src/kudu/client/table_statistics-internal.h@17 PS1, Line 17: #pragma once : > nit: use Done http://gerrit.cloudera.org:8080/#/c/14218/1/src/kudu/client/table_statistics-internal.h@20 PS1, Line 20: > nit: use Done http://gerrit.cloudera.org:8080/#/c/14218/1/src/kudu/client/table_statistics-internal.cc File src/kudu/client/table_statistics-internal.cc: PS1: > nit: These are super small and don't require extra includes. Consider putti Done -- To view, visit http://gerrit.cloudera.org:8080/14218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic00f46fd49c258f46a178a92d142d4d93d615d82 Gerrit-Change-Number: 14218 Gerrit-PatchSet: 2 Gerrit-Owner: ZhangYao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Comment-Date: Sun, 15 Sep 2019 16:38:27 +0000 Gerrit-HasComments: Yes
